Thanks a bunch for the link, Trudus. The version is fine. The conditions are pretty much fucked up though. Especially with the $nm. It counts it as the current target instead of the spell target what we had in Byte's version :( This kills nearly all of my cries.

Just to let everybody know, some others have also bee working on it. They released this version, which seems to incorporate a lot of peoples work (possibly including mine), and is working well for me so far. Give it a try. :) http://www.wowinterface.com/downloads/fileinfo.php?id=11569#info

My thanks to you Tridus !

Tridus, thanks a whole bunch for your work!

There's a FAQ in the official UI forums with links to things like the LUA manual, and some WoWWiki tutorials. Other then that, I'm learning by doing a lot of reading other peoples code, and trial and error. :)

Tridus, I tried to PM you but apparently the forums are broken because it wont let me. Id very much like to help you with battlecry, however, I know nothing about modding. If you could direct me to a good place to learn, I have quite a knack at coding, then I would put in the effort to learn and help you along with it.

I'm making an attempt at it guys. I've got the editor working again such that it loads, and you can edit things. If you don't disable UI errors you will get a LOT of them though. I haven't figured that out. However, in my early testing this version *DOES* function. You can download it here: http://www.hiredgoons.ca/BattleCry_Test.zip Please leave feedback here. No guarantee on how fast I can go since I'm a total novice at mod development. :)

Guys, the latest patch killed BattleCry again... I understand Byte is enjoying his real life and I'm so happy for him. But we, WoW nerds, mustn't let this awesome addon fade away. There must be a person somewhere who understands the coding and can find a little bit of motivation to update BattleCry. Please! WoW isn't WoW without BattleCry.

I have encountered some frustration with the last beta while attempting to build an emote. I'm using a custom trigger, named em-hostile-smile. The idea is to be able to use a random customly-designed emote with the slash command, inside of a spoken cry. So far, I have two cries setup for it: bare-targeted and bare-notarget. bare-targeted contains the variable $nm in its text, and bare-notarget has no variables. The idea was to check "exclusive" on the targeted version, so that it will behave more like a real emote-- use the one with a name in it if I have a target, otherwise, use the generalized one. The problem I've encountered is that when I checked the exclusive box, it applied to both cries. Is this a bug with the beta, or am I doing something wrong? ----------------------------------------- Edit: Rather than add a second post, I'll ask my next question here. Is it possible to setup BattleCry to watch /say and /emote as well as the combat log? I'm using PetEmote, and I'd like to be able to set it up so that my Succubus responds when people flirt with her (or me).

Congrats, Byte! Hope everything's going well to you and your family. Gief my hugs to your baby girl :)

You'll have to forgive my absence of late. My wife recently gave birth to our first child and we close on our first home in less than a month. Needless to say, things have been quite hectic. I'll do my best to fit in some coding whenever I can find some time and motivation to pull myself away from my beautiful daughter.

Bah, I don't miss WoW as much as I miss this addon. Gives me only good memories... If I renew my account someday (which might happen pretty soon as the addiction is crawling back into my brain), BC is the first addon I'll install. Best of luck to you, Bytey! :)

I am unable to get my cries to work. I have it set up so whenever I kill an enemy in the battlegrounds it yells a cry. when I make a kill, I get nothing. I know BC works for me cause it works for my rogue's saps ans other actions I have placed. Anyone else having this issue?

@Lissothus: Find out exactly what the name of your action is first. Do this by typing: /battlecry echo Now mount and it will give you a message in your chat telling you the exact name that you should use. Now open up the editor and go to the Custom category and add a new action that is the same name as what was echoed earlier. It is important that you capitalize correctly, as this is case sensitive! Now when you add cries to this custom action, they should execute properly. I can't say why conditions wouldn't work on your version. Are you using the french client, and have you downloaded the most recent beta version?

In first time, excuse my poor english... i'm just french ! ^__< So, i want to do a cry when i call my battle mount (horse, tiger or something else) but my different atempts came out onto failures... do you have a solution ? PS : the conditions doesn't work on my version.

A New Beta version is available. The big change here is the addition of the COMBAT_LOG_EVENT_UNFILTERED in the event watches as well as a needed change to the Cry Chain system. I'll explain the changes to the Cry Chains first since that's easier. If you have cry chains set up you will need to set them up again. The first thing you want to do is wipe out your old chains. The *best* way to do this is to go into the Cry Editor and select any cries that are attached to chains. Delete and immediately resave the cry. Do this for any cries that have chains and it will wipe out all chains and you can set them up again. You can also select the chains in the Chain tab and click Delete, but the first way is more likely to delete everything. Events... Because the previous version wasn't allowing you to save new event watches, you'll want to reset your event watches. This is really simple to do, simply type in the chat: /script BC_Data.events = nil Now reload your UI and you'll see new default events. If you don't do this you'll still see the old ones and that's fine but might cause some issues. How the COMBAT_LOG_EVENT_UNFILTERED event works. This event is fired for anything that is listed in your combat log. You need to select a prefix and a suffix of what type of combat log event this is. You can select the pre-defined ones to get a feel for it. Once you've selected a prefix and suffix you'll be presented with all of the arguments that are available for that combination. Please note that not all prefix-suffix combinations are possible in-game. Because I don't know everything that is and isn't available I didn't want to restrict any. Select an argument that you'd like to test against (similar to conditions), the test type and the value you want to test again. Click Save in the bottom-right to save that argument. Once you've saved all the arguments you want enter a name for your event watch and click Save in the upper-right to commit these changes. I'd advise you to make liberal use of the sourceName and targetName arguments. This is the easiest way to restrict which events trigger cries and which don't. I'm very interested to see how this works for everybody and am very open to suggestions for how to improve the interface in this particular area.

Well it's been a busy couple of weeks these past two. I've had some time (but not as much as I'd like!) to work on the events issues and have reached a point where they are working for COMBAT_LOG_EVENT. I need to add some interfacing for actually editing event watches of this special type and do some rigorous testing and then I can release a new beta version with the updates. Hopefully I'll have time to get this ready by the week's end. @Helghast: Thanks for the localization. Next update will contain localization variables for all the UI stuff. Your first problem of conditions should be sorted out now. I needed to correct code in two places and missed one of them on the previous update. Your other issue of not saving new events is a problem of it saving perfectly fine, but when you restart WoW, BattleCry immediately overwrites all your saved event watches with the defaults. Obviously, once I realized this I fixed it. @Quelsinna: The issue you're experiencing was fixed along with fixing Helghast's first reported issue. @animpinabox: Please read the IMPORTANT section of the description just above.

Hi, I have a question. When updating to a newer version, is there any way of keeping all the previous saved battlecrys that i used in the previous version? or do i have to retype them all? Thanks

Here a version of the localization file that I modified for the french client : http://big.chez-alice.fr/vargethrond//www/Divers/Localization.lua" target="_blank Note that I modified the encoding format to utf-8, because some caracters were not accepted in the original format ("é" "à", etc). This way, some german translations have been altered, but as far as in this language there is some specials caracters too, it should be a good thing after all :) The fact is that your german translator will have to modify his work :) Bye the way, there is some things that are not translated but which are not in the localization file at the moment : "cries" "chains" and "events" in the "chains" window : "Head of chain" "Tail of chain" "Saved chains" in the "events" window : "available events" "save new watch" "saved events watches" "Add" "Save" "Delete" "Watch name" Thanks again for all your great work ;)

As I'm testing : another problem I just can't whange any event in the event window. When I create a new watch, change an argument, add a new argument, delete an argument or even delete a watch, I can be sure that nothing really happens. When I modify something, it seems to be ok, but nothing is really changed in the facts : it's as if I had changed nothing. And in all cases : if I type /reloadui and look back in BC event window everything is returned to default. Watches deleted are back, watches added are gone, etc ... As an exemple : I take the watch "you slay hostile". As I'm using a french clien, I need to change the argument in "%s a tué %s !". I save and close the window. I add a cry for the event and set the frequency to 100 and CD to 0. I kill a monster and ... nothing. I look in the combat log and see "Seyphiria a tué bestiole" so something should have happen. I tested with a different argument to be sure "Seyphiria a tué %s !" and then nothing happens too. In fact, is often happens that : I add an argument, I click ADD, I click SAVE and then I select another watch. When I select back the "you slay hostile" watch ... all is returned to default. I hope you'll understand what I'm trying to explain :p

Hello there :) I'm actually testing the beta vetrsion, and the problem whith conditions automaticaly applyed to all cries seems to be solved ! Greats thanks for this :) But on the other hand, I have a problem too with the $nm variable : when I'm actually targeting myself, the thing goes in the way it's inteded too, but when I'm not targeting anything actively (the spell is cast on me then) nothing happens anymore (before the 2.4, when I was targeting nothing, it was as if I was targeting myself for all that concerns BC (I'm using the autotarget fonction in the interface options). For exemple, let's give an exemple : Cry 1 is set with the condition "target $nm == Seyphiria" (my char name) Cry 2 is set with no conditions Cry 3 is set with the condition "target $nm ~= Seyphiria" Then, when I target myself I have cry 1 or cry 2. Exactly as intended when I target an ally I have cry 2 or 3. Perfect here too But when I target nothing, I just have Cry 2 instead of Cry 2 or 1 A last thing for the moment : when I set $cl in a cry and if i'm targetting a NPC, I have its name instead of its class. It's perfect ! (I didn't test it on a player though, so I don't know if I'm going to have his name or his class) Are you behind that change or is it something due to a modification by Blizzard ? Excuse my poor english, again :)

Love you even more now (if that's possible). The COMBAT_LOG_EVENT means we're getting the funcionality of the custom events with those changes to the combat log in 2.4, or what? oO Edit: Trying the 3.01 now. The $nm seems still messed up for me. I'm back to that bird island in Terokkar, it'll be my testing place for now as it's usually empty so I can spam BC as much as I like without anyone thinking I've gone crazy. So I've set up PW:F's chance to 100%, cooldown to 0. I have lots of cries, but will take examples of 2 of them (they're really not-so-original, but anyway): "Light, bless me!". Has a condition "target $nm == Quelsinna". "May the Light bless you, $nm!". Has a condition "target $nm ~= Quelsinna". So when I'm targeting myself, I get the first one, which is good. But when I'm targeting a bird, or have no target at all, it gives me a "May the Light bless you, Quelsinna!" which makes no sense at all. :) In the old version this condition with "target $nm == / ~= Quelsinna" used to solve this problem. But I take it it's not the mod but those changes Blizz did to the game itself cause this now :( I have a thought it might be the "target" thing in the conditions, that it's "target" for your current target instead of spell's target. If anyone here has some idea how to solve this, you'd be more than welcome to share it and make me happy :)

All the bugs that I've fixed since the release a few days ago are now available in the Beta version for anyone who's freaking out and can't handle things not working exactly correctly (I find myself squarely in the midst of that camp myself). Check the beta version notes to see if what you're hoping for has been fixed. Thanks a ton to all of you who love BattleCry and are helping me to find and fix the errors. For those concerned, my ToDo list goes something like this: *sort through every line to make sure localization is possible (and convince someone to translate!) *expand event handling for COMBAT_LOG_EVENT *re-introduce the tooltips and help screens Cheers!

Ok, so I think I got my problem with conditions. It's all about that in this new version $nm is working for my current target instead of spell's target. Went to this druid island in Terokkar to spam abit. Did a cry "test $nm" for PW:F spell. Now targeted a bird and cast it. It should be "test Quelsinna" as it's a self cast when I got a hostile target on. But I'm getting "test Lost Torranche", mod seems to think I'm casting it on the bird? If I remember correctly, such behaviour used to occur in early versions of the mod, but then you fixed it. (or maybe it was in some other mod, my memory is really one empty void sometimes :S). To sum it up, could you please check in the $nm value when you have some spare time, maybe there's really some error? Edit: Just to add, if I have no target at all and do a self cast the cries with $nm value don't come up at all.

@Quelsinna: I just realized last night that I had completely forgotten about disabling the mod completely. That's definitely going back in soon. Not sure why the condition isn't working correctly, I'll take a look into that when I get a chance.

Much love for the update! [Edit: Just tried cries with double conditions, and they indeed work as "and" so it was either me being slightly retarded or I had some corrupt version of the mod] Anyway, now I'm facing some different "bug". Or I'm just stupid again, dunno :) But "target $nm ~= Quelsinna" doesn't work for me anymore :S I used to use this in 2.25 version for those cries that I didn't want to see when buffing myself. Now I get the cry with this condition when I'm buffing myself, and the cry with condition "target $nm == Quelsinna" doesn't come out at all... The strange thing is that it only occurs for Shadow Protection spell. Tried rechecking the spelling of my name ten times, but it seems OK. I know I'm usually annoying with my silly demands, but maybe you could do a tick, or a pop-up window for the self based cries, if that's possible at all? I mean, like what you did with the "ignore frequency". Also would be really nice if the possibility to test the conditions came back, was really useful when looking for errors. :) Gosh, I must say it again. I LUFF BATOLCRAI! Especially when people go "wtf" after stuff like "Foolish whelp, I will consume your energies... and then your soul!" (aka Vampiric Embrace) P.S.: Is the tick for disabling the mod coming back? *begs pathetically*

Re: Attack, thanks Byterunner! I'm glad I'm not looney after all! So far, everything else works just like it used to, and I appreciate your time in making such a great mod, esp for rp. Thanks again!

@Avengenist: I've done some snooping. It looks like Attack is handled a little bit differently and I'll have to put in a special case to accommodate for that. @Helghast: I am unable to reproduce the issue you're describing. Here's what I did... I already have 6 cries with no conditions set up for the action "Pet Attack" and want to add a condition to one of them. I open up the editor, go to category Pet, action Pet Attack and see my six cries. I select the fourth one, "Go For The Eyes" and see that the Conditions button has a (0) on it. I click conditions and enter the following: Target: "target" Variable: "$ct" Test: "==" Value: "humanoid" Now I click Add to add this condition to the list and then Save to save the cry with this condition. Now I can see that the Condition button has a (1) and I select a different cry for that action, "Kneecaps". The Condition button changes to "Conditions (0)". When I click on the Conditions button I see an empty list, but I do see my previous values in the text and dropdown boxes ready to be added to this new cry. Because they show up there doesn't mean they are a part of my cry, only if they show up in the list. I then closed down WoW and opened my BattleCry_Core.lua file in my SavedVariables folder and confirmed that only the cry "Go For The Eyes" has the condition, the rest have no conditions saved to them. Have you tested your cries after adding the condition to one to verify that it does in fact apply to all of them? Now, here's a process that would cause the issue you're describing: Open up the editor, select an action that has no cries on it. Create a new cry that has a condition and save it. Now change the name and text and save a new cry. This new cry will automatically inherit the conditions of the previous cry because the conditions were not cleared out. This is an intentional behavior to allow you to save the same cry with the same conditions to multiple actions if you wanted without having to retype everything. If you wan to create a brand new cry from scratch, hit the New button and it will clear everything out, including Conditions. Let me know if this helps. If the problem still persists, I can look deeper into it.

The problem is that when I add a condition for a cry of a given action, all the other cries for this action receive the same condition automaticaly. The box with the button which indicates the number of conditions for the cry seems to be the same for all cries of this action.

Everything is pretty much working well. Cries work fine with things like summon charger, I created a couple for crusader strike. But for the life of me, I can't get any cry to work on General / Attack. I'm a ret pali, have "Attack" in my #1 slot in my tool bar. I tried pressing attack from the spellbook and nothing also. I created a simple cry for this, 100%, no cooldown, called it Attack1, named it, no multiplier, boxes unchecked and tried it with cry when action starts and completes. Language is orcish, output is say. When I hit save, it shows in the log "Cry 'Attack1' saved to action [Attack]. and test works. But when I press attack, I get nothing. But all other cries are working perfectly, 100% or not. Thoughts?

Ah, didn't notice you renamed the folder structure. Ok, yeah that would do it. Thanks!

@Avengenist: Turn off your old version of BattleCry. Those errors are from the old version that is not 2.4 compatible. If you need to transfer your old cries to the new version, there are instructions to do so in the patch notes above. Once you've done that, make sure you uncheck the AddOn titled simply "BattleCry" and leave the two titled "BattleCry_Core" and "BattleCry_Editor" checked. I would advise removing the old version completely from your AddOn folder so as to alleviate any confusion.

Not intended at ALL! I'm not sure why it would be doing this, I've looked into it and I'm not sure how you're only seeing conditions specified per action instead of per cry. Can you please elaborate on how you're reaching this conclusion? On a related note, I did find an issue with certain condition variables that cause an error: health percent, mana percent, guild name, is in your raid, item main/off/range and event variables currently will give an error if you use them in a condition. I'll get a fix for this as soon as possible.

Thank you so much for this update :) Now let's speak about bugs ! I noticed that conditions can now only be specified for a given action, not a specific cry. Is this intended to ?

@Quelsinna: It should be doing "and" instead of "or". I'll double-check to make sure it is functioning that way in the new version. @Helghast: I aim to please. I'm still in the process of putting the "shinies" back on this new version, including localization. Feel free to point out places where my translation is out of whack or just plain missing if you're up for translating still! Next update will mostly be for localization purposes and to fix any minor bugs that snuck through.

Just as a side note, is there a way (or a way to add such function) to make "and" conditions, instead of only "or"? I mean I'd love to make an Abolish Disease working only on BE males: "How many times do I have to tell you, $nm, that being gay is not a disease I can cure??". In the last version it was checking if target was either BE or male. :( Or was I doing something wrong?

"cry" Oh Byterunner, you're back ! I'm REALLY happy to read this ! I never stopped using battlecry, hoping it will last forever and ... 2.4 occured and then my favorite addon stopped to work. If you need any help I'm here !

Really looking forward to this being fixed. I had occasion to group with a few people and some of my emotes were VERY well timed. Lots of good laughs. My emote for enemy death " Say Hi to your Mom for me.."(2% activate) was very well received.;) I will beta test should you need someone.

*dodges Quelsinna* So I had a version that was just about ready for release, and then 2.4 hit, so it's back to the testing phase. If anyone wants an advanced version to help me test any kind of issues presented in 2.4 I'm happy to oblige. Just send me a PM with your email and I'll send you a copy that works (as far as I've tested) with 2.4.

Byterunner, I'd slap you to death IRL if I knew you! What took you so long to get back? :) Anyway, BC is my top of the tops add-on, really great job, man. And I almost fell to tears when I saw it wasn't working anymore with the 2.4. So really looking forward to see it updated :) Thanks for your work

Sweet, welcome back!

Awsome! Thank you ByteRunner, this has been one of my all time favorite mods and I'm so glad to hear you are back in game and are updating the mod. If you need any external testers, please let me know. Avengenist

I'm back playing WoW again and have begun the task of updating BattleCry. It is currently in the testing phase and I should have a new release out within a week or two that addresses issues with recent patches.

Greetings! This is an awesome mod.. an we use this addon to give our ingame fights an situations more rpfeeling. Since patch 2.2 the mod doesn't support checking your buffs. perhaps you can fix it an upload a new version? Bye Bo